Skip to content

Implementation of Binary Image Classification#79

Open
harisalam wants to merge 41 commits intomainfrom
newFeature2022-11-08
Open

Implementation of Binary Image Classification#79
harisalam wants to merge 41 commits intomainfrom
newFeature2022-11-08

Conversation

@harisalam
Copy link
Contributor

Binary Image classification has been implemented which can be tested using the following command:

python visual data/

data/ is the directory where different classes images should be present like sad and happy

@harisalam harisalam added the enhancement New feature or request label Dec 16, 2022
@harisalam harisalam self-assigned this Dec 16, 2022
@vercel
Copy link

vercel bot commented Dec 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ml-code-generator ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 5:35AM (UTC)

@harisalam harisalam linked an issue Dec 16, 2022 that may be closed by this pull request
numpy
google-api-python-client No newline at end of file
tensorflow
tensorflow-gpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to run pip3 install -r requirements.txt the tensorflow-gpu module can not be found. Returning these errors: ERROR: Could not find a version that satisfies the requirement tensorflow-gpu (from versions: none) and
ERROR: No matching distribution found for tensorflow-gpu

@john-coffman
Copy link
Collaborator

I reviewed the pull request and for the most part the code looks good. Here are just a couple things I thought needed attention.

  1. I don't think we should be uploading .DS_Store or at least I don't now what its adding.
  2. If we are adding "stevensona.character-count" to devcontainer.json I don't think we should add extensions.json in our main repo.
  3. The linear regression model uses possum.csv for there testing so I don't think we should remove it from data.
  4. I tried to run the code but I don't have any test images so I got ValueError: No images found in directory data/. Allowed formats: ('.bmp', '.gif', '.jpeg', '.jpg', '.png'). So I think you should have some test images added to data so we could run it to get an idea of how it works.

@harisalam
Copy link
Contributor Author

I reviewed the pull request and for the most part the code looks good. Here are just a couple things I thought needed attention.

  1. I don't think we should be uploading .DS_Store or at least I don't now what its adding.

  2. If we are adding "stevensona.character-count" to devcontainer.json I don't think we should add extensions.json in our main repo.

  3. The linear regression model uses possum.csv for there testing so I don't think we should remove it from data.

  4. I tried to run the code but I don't have any test images so I got ValueError: No images found in directory data/. Allowed formats: ('.bmp', '.gif', '.jpeg', '.jpg', '.png'). So I think you should have some test images added to data so we could run it to get an idea of how it works.

I'll be able to address all of your concerns in the new pull request. Thanks for bringing up the issues it will really help me to focus on specific areas where changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow image data

2 participants